Conversation
There was a problem hiding this comment.
Pull request overview
Adds configuration options to change how small-scale marginalization templates are handled during fitting, including an on-the-fly template-coefficient fit mode and an option to build templates that match data-bin structure; also adds a small CLI runner.
Changes:
- Add
control.marginalize_in_fitto optionally fit marginalization-template coefficients on the fly duringchi2. - Add
model.marginalize-match-data-binsand plumb it through config building and template construction. - Add
bin/run_vega.pyconvenience entrypoint.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| vega/vega_interface.py | Adds marginalize_in_fit wiring, applies fitted template corrections in chi2, and guards global-cov updates when cov_marg_update is None. |
| vega/data.py | Extends Data init to support marginalize_in_fit by optionally skipping covariance updates and adjusting the coefficient-solver setup. |
| vega/correlation_item.py | Adds marginalize-match-data-bins and a new template-building path that groups model bins by nearest data bins. |
| vega/build_config.py | Adds the new marginalize-match-data-bins option to generated configs. |
| bin/run_vega.py | Adds a simple CLI wrapper around vega.run_vega. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 37.12% 36.90% -0.23%
==========================================
Files 30 30
Lines 4180 4208 +28
Branches 788 798 +10
==========================================
+ Hits 1552 1553 +1
- Misses 2470 2494 +24
- Partials 158 161 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.